feat(pomodoro): Add Web Audio API sound alert on timer completion (#81) - #86
Open
Shivang9983 wants to merge 3 commits into
Open
feat(pomodoro): Add Web Audio API sound alert on timer completion (#81)#86Shivang9983 wants to merge 3 commits into
Shivang9983 wants to merge 3 commits into
Conversation
Contributor
Author
|
I have updated the code and resolved the issue as requested. Could you please review and merge the PR when you get a chance? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #81
🛠️ Changes
client/src/hooks/usePomodoro.jsusing the Web Audio API.00:00.🧪 Test
Set timer to 5 seconds, let it hit zero, and verify the sound plays.